From: Remi Tricot-Le Breton <rlebreton@haproxy.com>
Date: Wed, 12 Nov 2025 14:58:33 +0000 (+0100)
Subject: BUG/MEDIUM: init: 'devnullfd' not properly closed for master
X-Git-Tag: v3.3-dev13~48
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1b19e4ef32301e1f469ebc82e9f88938ec8b6d95;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: init: 'devnullfd' not properly closed for master

Since commit "1ec59d3 MINOR: init: Make devnullfd global and create it
earlier in init" the devnullfd pointing towards /dev/null gets created
early in the init process but it was closed after the call to
"mworker_run_master". The master process never got to the FD closing
code and we had an FD leak.

This patch does not need to be backported.
---

diff --git a/src/mworker.c b/src/mworker.c
index fea592008..ab0e0547d 100644
--- a/src/mworker.c
+++ b/src/mworker.c
@@ -1151,6 +1151,9 @@ void mworker_run_master(void)
 {
 	struct mworker_proc *child, *it;
 
+	close(devnullfd);
+	devnullfd = -1;
+
 	proc_self->failedreloads = 0; /* reset the number of failure */
 	mworker_loop();
 #if defined(USE_OPENSSL) && !defined(OPENSSL_NO_DH)