From: Steve French <smfrench@gmail.com>
Date: Thu, 29 Sep 2016 09:20:23 +0000 (-0500)
Subject: Cleanup missing frees on some ioctls
X-Git-Tag: v3.16.40~186
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1b40078c2b53f5c0264830eab1f1bbd237421eb8;p=thirdparty%2Fkernel%2Fstable.git

Cleanup missing frees on some ioctls

commit 24df1483c272c99ed88b0cba135d0e1dfdee3930 upstream.

Cleanup some missing mem frees on some cifs ioctls, and
clarify others to make more obvious that no data is returned.

Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
[bwh: Backported to 3.16:
 - Drop changes to smb2_duplicate_extents(), smb3_set_integrity()
 - Adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 394977d546628..6cfc4ea3f3a1f 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -228,7 +228,7 @@ SMB3_request_interfaces(const unsigned int xid, struct cifs_tcon *tcon)
 			le64_to_cpu(out_buf->LinkSpeed));
 	} else
 		cifs_dbg(VFS, "error %d on ioctl to get interface list\n", rc);
-
+	kfree(out_buf);
 	return rc;
 }
 #endif /* STATS2 */
@@ -640,6 +640,7 @@ smb2_clone_range(const unsigned int xid,
 
 cchunk_out:
 	kfree(pcchunk);
+	kfree(retbuf);
 	return rc;
 }