From: Raymond Hettinger <python@rcn.com>
Date: Thu, 14 Feb 2008 09:32:45 +0000 (+0000)
Subject: Add diagnostic message to help figure-out why SocketServer tests occasionally crash
X-Git-Tag: v2.6a1~174
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1b5632445be2dba6c66162749cc8bbf8dff887d1;p=thirdparty%2FPython%2Fcpython.git

Add diagnostic message to help figure-out why SocketServer tests occasionally crash
when trying to remove a pid that in not in the activechildren list.
---

diff --git a/Lib/SocketServer.py b/Lib/SocketServer.py
index 2eed9144921f..1763c1d5e47c 100644
--- a/Lib/SocketServer.py
+++ b/Lib/SocketServer.py
@@ -452,7 +452,11 @@ class ForkingMixIn:
             except os.error:
                 pid = None
             if not pid: break
-            self.active_children.remove(pid)
+            try:
+                self.active_children.remove(pid)
+            except ValueError, e:
+                raise ValueError('%s. x=%d and list=%r' % (e.message, pid,
+                                                           self.active_children))
 
     def handle_timeout(self):
         """Wait for zombies after self.timeout seconds of inactivity.