From: Christian Ambach <ambi@samba.org>
Date: Tue, 22 Oct 2019 09:02:05 +0000 (+0200)
Subject: s3:lib:wins fix a compile warning on Ubuntu 18.04
X-Git-Tag: talloc-2.3.1~253
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1b69795c5bbc2ed24c54f8295fd3d9e4e0a0f938;p=thirdparty%2Fsamba.git

s3:lib:wins fix a compile warning on Ubuntu 18.04

gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1) with -O2 puts up a warning here:
../../source3/lib/wins_srv.c: In function ‘wins_srv_tags’:
../../source3/lib/wins_srv.c:235:3: error: assuming signed overflow does not
occur when simplifying conditional to constant [-Werror=strict-overflow]
   for (j=0;j<count;j++) {
   ^~~
cc1: all warnings being treated as errors

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>

Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Wed Oct 23 04:57:09 UTC 2019 on sn-devel-184
---

diff --git a/source3/lib/wins_srv.c b/source3/lib/wins_srv.c
index 4872d1c75b3..23796a2c5f4 100644
--- a/source3/lib/wins_srv.c
+++ b/source3/lib/wins_srv.c
@@ -208,7 +208,7 @@ static void parse_ip(struct tagged_ip *ip, const char *str)
 char **wins_srv_tags(void)
 {
 	char **ret = NULL;
-	int count=0, i, j;
+	unsigned int count=0, i, j;
 	const char **list;
 
 	if (lp_we_are_a_wins_server()) {