From: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com>
Date: Mon, 25 Sep 2023 15:38:06 +0000 (+0300)
Subject: gh-109795: `_thread.start_new_thread`: allocate thread bootstate using raw memory... 
X-Git-Tag: v3.13.0a1~304
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1b8f2366b38c87b0450d9c15bdfdd4c4a2fc3a01;p=thirdparty%2FPython%2Fcpython.git

gh-109795: `_thread.start_new_thread`: allocate thread bootstate using raw memory allocator (#109808)
---

diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c
index 9c915488f6e0..fa98df516b8b 100644
--- a/Modules/_threadmodule.c
+++ b/Modules/_threadmodule.c
@@ -1066,7 +1066,7 @@ thread_bootstate_free(struct bootstate *boot, int decref)
         Py_DECREF(boot->args);
         Py_XDECREF(boot->kwargs);
     }
-    PyMem_Free(boot);
+    PyMem_RawFree(boot);
 }
 
 
@@ -1184,13 +1184,16 @@ thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
         return NULL;
     }
 
-    struct bootstate *boot = PyMem_NEW(struct bootstate, 1);
+    // gh-109795: Use PyMem_RawMalloc() instead of PyMem_Malloc(),
+    // because it should be possible to call thread_bootstate_free()
+    // without holding the GIL.
+    struct bootstate *boot = PyMem_RawMalloc(sizeof(struct bootstate));
     if (boot == NULL) {
         return PyErr_NoMemory();
     }
     boot->tstate = _PyThreadState_New(interp);
     if (boot->tstate == NULL) {
-        PyMem_Free(boot);
+        PyMem_RawFree(boot);
         if (!PyErr_Occurred()) {
             return PyErr_NoMemory();
         }