From: Volker Lendecke <vl@samba.org>
Date: Thu, 30 Jul 2026 12:25:54 +0000 (+0200)
Subject: libcli: Slightly streamline sddl_flags_to_string()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1ba2ec9cf8bc5c958eaf14ded6f3dccf8f3affac;p=thirdparty%2Fsamba.git

libcli: Slightly streamline sddl_flags_to_string()

Only check for talloc failure once with talloc_asprintf_addbuf()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index 215321adb61..fe24d4892b2 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -1051,12 +1051,15 @@ static char *sddl_flags_to_string(TALLOC_CTX *mem_ctx, const struct flag_map *ma
 	/* now by bits */
 	for (i=0;map[i].name;i++) {
 		if ((flags & map[i].flag) != 0) {
-			s = talloc_asprintf_append_buffer(s, "%s", map[i].name);
-			if (s == NULL) goto failed;
+			talloc_asprintf_addbuf(&s, "%s", map[i].name);
 			flags &= ~map[i].flag;
 		}
 	}
 
+	if (s == NULL) {
+		goto failed;
+	}
+
 	if (check_all && flags != 0) {
 		goto failed;
 	}