From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 13 Apr 2026 10:28:11 +0000 (+0200)
Subject: dnsdist: Fix out-of-bounds read in SetMacAddrAction
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1be86a8089ae70e6ff76bede89fa58f6200cde5a;p=thirdparty%2Fpdns.git

dnsdist: Fix out-of-bounds read in SetMacAddrAction

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-actions-factory.cc b/pdns/dnsdistdist/dnsdist-actions-factory.cc
index ded8a537dc..81795dff0f 100644
--- a/pdns/dnsdistdist/dnsdist-actions-factory.cc
+++ b/pdns/dnsdistdist/dnsdist-actions-factory.cc
@@ -986,9 +986,10 @@ public:
       return Action::None;
     }
 
-    std::string optRData;
     // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast)
-    generateEDNSOption(d_code, reinterpret_cast<const char*>(mac.data()), optRData);
+    std::string macStr(reinterpret_cast<const char*>(mac.data()), mac.size());
+    std::string optRData;
+    generateEDNSOption(d_code, macStr, optRData);
 
     if (dnsquestion->getHeader()->arcount > 0) {
       bool ednsAdded = false;