From: Jeremy Allison <jra@samba.org>
Date: Fri, 5 Feb 2016 21:21:29 +0000 (-0800)
Subject: asn1: Ensure asn1_tag_remaining() only ever returns -1 as an error condition.
X-Git-Tag: tevent-0.9.27~38
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1d26012ce84d12cba236e5a88be25e6d489c9144;p=thirdparty%2Fsamba.git

asn1: Ensure asn1_tag_remaining() only ever returns -1 as an error condition.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Feb 10 01:38:03 CET 2016 on sn-devel-144
---

diff --git a/lib/util/asn1.c b/lib/util/asn1.c
index 029265e2b86..9d6d4164f10 100644
--- a/lib/util/asn1.c
+++ b/lib/util/asn1.c
@@ -721,6 +721,10 @@ int asn1_tag_remaining(struct asn1_data *data)
 		data->has_error = true;
 		return -1;
 	}
+	if (remaining < 0) {
+		data->has_error = true;
+		return -1;
+	}
 	return remaining;
 }