From: Michael Adam <obnox@samba.org>
Date: Tue, 4 Sep 2012 13:19:46 +0000 (+0200)
Subject: s3: in sys_popen(), untangle assigment from check and add a debug message in failure... 
X-Git-Tag: samba-4.0.0rc1~244
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1d4fe78db928c5f68aa805d1f5dc6a941fbb10fc;p=thirdparty%2Fsamba.git

s3: in sys_popen(), untangle assigment from check and add a debug message in failure case
---

diff --git a/source3/lib/system.c b/source3/lib/system.c
index 30f2ac6d008..94603305370 100644
--- a/source3/lib/system.c
+++ b/source3/lib/system.c
@@ -1176,8 +1176,11 @@ int sys_popen(const char *command)
 	parent_end = pipe_fds[0];
 	child_end = pipe_fds[1];
 
-	if((entry = SMB_MALLOC_P(popen_list)) == NULL)
+	entry = SMB_MALLOC_P(popen_list);
+	if (entry == NULL) {
+		DEBUG(0, ("sys_popen: malloc failed\n"));
 		goto err_exit;
+	}
 
 	ZERO_STRUCTP(entry);