From: Hui Cao (huica) <huica@cisco.com>
Date: Fri, 4 May 2018 15:24:40 +0000 (-0400)
Subject: Merge pull request #1211 in SNORT/snort3 from proto_ref_test to master
X-Git-Tag: 3.0.0-245~24
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1d693a773e12026296a9dbc4d59c7b93c032be2b;p=thirdparty%2Fsnort3.git

Merge pull request #1211 in SNORT/snort3 from proto_ref_test to master

Squashed commit of the following:

commit f13afb877073cc8851a9847bce9185a931c62bd5
Author: Victor Roemer <viroemer@cisco.com>
Date:   Tue May 1 11:40:52 2018 -0400

    target_based: 100% coverage on snort_protocols.cc
---

diff --git a/src/target_based/test/proto_ref_test.cc b/src/target_based/test/proto_ref_test.cc
index a30132275..977c32568 100644
--- a/src/target_based/test/proto_ref_test.cc
+++ b/src/target_based/test/proto_ref_test.cc
@@ -186,6 +186,13 @@ TEST(protocol_reference, constructors)
     CHECK( refs.find("unknown") == unknown );
 }
 
+// Verify calling get_name(id) where id > id_map.size() returns "unknown".
+TEST(protocol_reference, getname_gt_mapsize)
+{
+    ProtocolReference refs;
+    CHECK( std::string(refs.get_name(100)) == "unknown"  );
+}
+
 int main(int argc, char** argv)
 {
     return CommandLineTestRunner::RunAllTests(argc, argv);