From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Tue, 15 Dec 2015 17:42:40 +0000 (+0000)
Subject: utils: Improve traceback from better_exec internal errors
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1d710ed484f68fca0789022dde7ba877b9a894f5;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

utils: Improve traceback from better_exec internal errors

If you break the internals of better_exec(), you get a very weird
error about tb_next not being a method of None. Fix this by checking
we can step back a trace level.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/lib/bb/utils.py b/lib/bb/utils.py
index c5ff903ceff..e564bb6ff46 100644
--- a/lib/bb/utils.py
+++ b/lib/bb/utils.py
@@ -327,8 +327,10 @@ def _print_exception(t, value, tb, realfile, text, context):
         exception = traceback.format_exception_only(t, value)
         error.append('Error executing a python function in %s:\n' % realfile)
 
-        # Strip 'us' from the stack (better_exec call)
-        tb = tb.tb_next
+        # Strip 'us' from the stack (better_exec call) unless that was where the 
+        # error came from
+        if tb.tb_next is not None:
+            tb = tb.tb_next
 
         textarray = text.split('\n')