From: Tobias Mueller <tobiasmue@gnome.org>
Date: Mon, 12 Apr 2010 17:26:31 +0000 (+0100)
Subject: gobject-introspection: Use proper format string for g_error
X-Git-Tag: 0.9.1~37
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1d9db2c6f08f73b1620781279db936fc5c6c6485;p=thirdparty%2Fvala.git

gobject-introspection: Use proper format string for g_error

g_error expects a format string as first argument which it is now
given. This fixes a potential format string vulnerability.

Fixes bug 615552.
---

diff --git a/gobject-introspection/scanner.c b/gobject-introspection/scanner.c
index 43a8303e8..d98af491f 100644
--- a/gobject-introspection/scanner.c
+++ b/gobject-introspection/scanner.c
@@ -1582,7 +1582,7 @@ g_igenerator_start_preprocessor (GIGenerator *igenerator,
   tmp = g_file_open_tmp (NULL, &tmpname, &error);
   if (error != NULL)
     {
-      g_error (error->message);
+      g_error ("%s", error->message);
       return NULL;
     }
 
@@ -1617,7 +1617,7 @@ g_igenerator_start_preprocessor (GIGenerator *igenerator,
   f = fdopen (tmp, "r");
   if (!f)
     {
-      g_error (strerror (errno));
+      g_error ("%s", strerror (errno));
       unlink (tmpname);
       g_free (tmpname);
       return NULL;