From: David Tardon <dtardon@redhat.com>
Date: Wed, 30 Nov 2022 14:44:25 +0000 (+0100)
Subject: ratelimit: drop use of goto
X-Git-Tag: v253-rc1~294^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1dca43db12142441f3f653c72f51c15362ebfb79;p=thirdparty%2Fsystemd.git

ratelimit: drop use of goto
---

diff --git a/src/basic/ratelimit.c b/src/basic/ratelimit.c
index c16c8f7103a..f90a63b1a90 100644
--- a/src/basic/ratelimit.c
+++ b/src/basic/ratelimit.c
@@ -10,6 +10,7 @@
 
 bool ratelimit_below(RateLimit *r) {
         usec_t ts;
+        bool good = false;
 
         assert(r);
 
@@ -24,18 +25,12 @@ bool ratelimit_below(RateLimit *r) {
 
                 /* Reset counter */
                 r->num = 0;
-                goto good;
-        }
+                good = true;
+        } else if (r->num < r->burst)
+                good = true;
 
-        if (r->num < r->burst)
-                goto good;
-
-        r->num++;
-        return false;
-
-good:
         r->num++;
-        return true;
+        return good;
 }
 
 unsigned ratelimit_num_dropped(RateLimit *r) {