From: Volker Lendecke <vl@samba.org>
Date: Wed, 4 Sep 2019 09:32:58 +0000 (+0200)
Subject: torture: Fix the FreeBSD clang build
X-Git-Tag: talloc-2.3.1~989
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1e2d209494769cb23f10d3c8f8f294acdc9147f6;p=thirdparty%2Fsamba.git

torture: Fix the FreeBSD clang build

clang complained that "full_filename==NULL" is always false, because
it's a normal stack variable.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep  4 18:20:22 UTC 2019 on sn-devel-184
---

diff --git a/source4/torture/libsmbclient/libsmbclient.c b/source4/torture/libsmbclient/libsmbclient.c
index 7bc407ac905..b74d87aabed 100644
--- a/source4/torture/libsmbclient/libsmbclient.c
+++ b/source4/torture/libsmbclient/libsmbclient.c
@@ -421,7 +421,7 @@ static bool torture_libsmbclient_readdirplus_seek(struct torture_context *tctx)
 		filename[i] = talloc_asprintf(tctx,
 				"test_readdirplus_%u.txt",
 				i);
-		if (full_filename == NULL) {
+		if (filename[i] == NULL) {
 			torture_fail_goto(tctx,
 				done,
 				"talloc fail\n");
@@ -430,7 +430,7 @@ static bool torture_libsmbclient_readdirplus_seek(struct torture_context *tctx)
 				"%s/%s",
 				dname,
 				filename[i]);
-		if (full_filename == NULL) {
+		if (full_filename[i] == NULL) {
 			torture_fail_goto(tctx,
 				done,
 				"talloc fail\n");