From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Mon, 30 Jun 2025 22:19:14 +0000 (+0200) Subject: [3.13] gh-133982: Use implementation-specific `open` in `test_fileio.OtherFileTests... X-Git-Tag: v3.13.6~148 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1e3466a1ae5bdcee42a3dfdbd8aaa17135a6ecc2;p=thirdparty%2FPython%2Fcpython.git [3.13] gh-133982: Use implementation-specific `open` in `test_fileio.OtherFileTests` (GH-135364) (GH-136149) gh-133982: Use implementation-specific `open` in `test_fileio.OtherFileTests` (GH-135364) (cherry picked from commit 23caccf74ce2c8dc5d9c5eb6350d21ef20c6ea0b) Co-authored-by: Cody Maloney --- diff --git a/Lib/test/test_fileio.py b/Lib/test/test_fileio.py index 0611d1749f41..fdb36ed997d0 100644 --- a/Lib/test/test_fileio.py +++ b/Lib/test/test_fileio.py @@ -451,7 +451,7 @@ class OtherFileTests: try: f.write(b"abc") f.close() - with open(TESTFN_ASCII, "rb") as f: + with self.open(TESTFN_ASCII, "rb") as f: self.assertEqual(f.read(), b"abc") finally: os.unlink(TESTFN_ASCII) @@ -468,7 +468,7 @@ class OtherFileTests: try: f.write(b"abc") f.close() - with open(TESTFN_UNICODE, "rb") as f: + with self.open(TESTFN_UNICODE, "rb") as f: self.assertEqual(f.read(), b"abc") finally: os.unlink(TESTFN_UNICODE) @@ -552,13 +552,13 @@ class OtherFileTests: def testAppend(self): try: - f = open(TESTFN, 'wb') + f = self.FileIO(TESTFN, 'wb') f.write(b'spam') f.close() - f = open(TESTFN, 'ab') + f = self.FileIO(TESTFN, 'ab') f.write(b'eggs') f.close() - f = open(TESTFN, 'rb') + f = self.FileIO(TESTFN, 'rb') d = f.read() f.close() self.assertEqual(d, b'spameggs') @@ -594,6 +594,7 @@ class OtherFileTests: class COtherFileTests(OtherFileTests, unittest.TestCase): FileIO = _io.FileIO modulename = '_io' + open = _io.open @cpython_only def testInvalidFd_overflow(self): @@ -615,6 +616,7 @@ class COtherFileTests(OtherFileTests, unittest.TestCase): class PyOtherFileTests(OtherFileTests, unittest.TestCase): FileIO = _pyio.FileIO modulename = '_pyio' + open = _pyio.open def test_open_code(self): # Check that the default behaviour of open_code matches