From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 5 Jul 2021 15:55:24 +0000 (+0200)
Subject: wolfssl: failing to set a session id is not reason to error out
X-Git-Tag: curl-7_78_0~52
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1e488d38c966ec9b8838f5766c88f6092d06a7d8;p=thirdparty%2Fcurl.git

wolfssl: failing to set a session id is not reason to error out

... as it is *probably* just timed out.

Reported-by: Francisco Munoz

Closes #7358
---

diff --git a/lib/vtls/wolfssl.c b/lib/vtls/wolfssl.c
index 8d217ec54e..d21c007c19 100644
--- a/lib/vtls/wolfssl.c
+++ b/lib/vtls/wolfssl.c
@@ -494,15 +494,11 @@ wolfssl_connect_step1(struct Curl_easy *data, struct connectdata *conn,
                               &ssl_sessionid, NULL, sockindex)) {
       /* we got a session id, use it! */
       if(!SSL_set_session(backend->handle, ssl_sessionid)) {
-        char error_buffer[WOLFSSL_MAX_ERROR_SZ];
-        Curl_ssl_sessionid_unlock(data);
-        failf(data, "SSL: SSL_set_session failed: %s",
-              ERR_error_string(SSL_get_error(backend->handle, 0),
-                               error_buffer));
-        return CURLE_SSL_CONNECT_ERROR;
+        Curl_ssl_delsessionid(data, ssl_sessionid);
+        infof(data, "Can't use session ID, going on without\n");
       }
-      /* Informational message */
-      infof(data, "SSL re-using session ID\n");
+      else
+        infof(data, "SSL re-using session ID\n");
     }
     Curl_ssl_sessionid_unlock(data);
   }