From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Fri, 6 Oct 2023 02:07:24 +0000 (+1300)
Subject: s3:rpcclient: Do not pass uninitialized pointer to printf() (CID 1476170)
X-Git-Tag: tevent-0.16.0~63
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1e4d4e6abd3ce42d62b9a760d2b2ddc297e8d574;p=thirdparty%2Fsamba.git

s3:rpcclient: Do not pass uninitialized pointer to printf() (CID 1476170)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/rpcclient/cmd_spoolss.c b/source3/rpcclient/cmd_spoolss.c
index dc8bbd16185..f425e75f1ab 100644
--- a/source3/rpcclient/cmd_spoolss.c
+++ b/source3/rpcclient/cmd_spoolss.c
@@ -2129,7 +2129,7 @@ static WERROR cmd_spoolss_getprintprocdir(struct rpc_pipe_client *cli,
 	const char *environment = SPOOLSS_ARCHITECTURE_NT_X86;
 	DATA_BLOB buffer;
 	uint32_t offered;
-	union spoolss_PrintProcessorDirectoryInfo info;
+	union spoolss_PrintProcessorDirectoryInfo info = {};
 	uint32_t needed;
 	struct dcerpc_binding_handle *b = cli->binding_handle;
 
@@ -2173,7 +2173,7 @@ static WERROR cmd_spoolss_getprintprocdir(struct rpc_pipe_client *cli,
 		}
 	}
 
-	if (W_ERROR_IS_OK(result)) {
+	if (W_ERROR_IS_OK(result) && info.info1.directory_name != NULL) {
 		printf("%s\n", info.info1.directory_name);
 	}