From: Darrick J. Wong <djwong@kernel.org>
Date: Mon, 29 Jul 2024 23:22:51 +0000 (-0700)
Subject: xfs: remove pointless unlocked assertion
X-Git-Tag: v6.10.0~24^2~34
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1e6d0459ba23df9329e8cc66f449916a69965807;p=thirdparty%2Fxfsprogs-dev.git

xfs: remove pointless unlocked assertion

Source kernel commit: 13db7007892694c891fc37feccbd2ac8f227af78

Remove this assertion about the inode not having an attr fork from
xfs_bmap_add_attrfork because the function handles that case just fine.
Weirder still, the function actually /requires/ the caller not to hold
the ILOCK, which means that its accesses are not stabilized.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c
index 81dccf27..4cd0ffa4 100644
--- a/libxfs/xfs_bmap.c
+++ b/libxfs/xfs_bmap.c
@@ -1035,8 +1035,6 @@ xfs_bmap_add_attrfork(
 	int			logflags;	/* logging flags */
 	int			error;		/* error return value */
 
-	ASSERT(xfs_inode_has_attr_fork(ip) == 0);
-
 	mp = ip->i_mount;
 	ASSERT(!XFS_NOT_DQATTACHED(mp, ip));