From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 3 Sep 2020 14:56:30 +0000 (+0200)
Subject: udev-test: use SYNTHETIC_ERRNO() where useful
X-Git-Tag: v247-rc1~303^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1e7a67ec22f8af6087aaf0b9df399976f49463a1;p=thirdparty%2Fsystemd.git

udev-test: use SYNTHETIC_ERRNO() where useful
---

diff --git a/src/test/test-udev.c b/src/test/test-udev.c
index 968bfb32384..c7d69e07746 100644
--- a/src/test/test-udev.c
+++ b/src/test/test-udev.c
@@ -63,10 +63,9 @@ static int run(int argc, char *argv[]) {
 
         test_setup_logging(LOG_INFO);
 
-        if (!IN_SET(argc, 2, 3)) {
-                log_error("This program needs one or two arguments, %d given", argc - 1);
-                return -EINVAL;
-        }
+        if (!IN_SET(argc, 2, 3))
+                return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
+                                       "This program needs one or two arguments, %d given", argc - 1);
 
         r = fake_filesystems();
         if (r < 0)
@@ -79,10 +78,9 @@ static int run(int argc, char *argv[]) {
         mac_selinux_retest();
 
         if (argc == 2) {
-                if (!streq(argv[1], "check")) {
-                        log_error("Unknown argument: %s", argv[1]);
-                        return -EINVAL;
-                }
+                if (!streq(argv[1], "check"))
+                        return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
+                                               "Unknown argument: %s", argv[1]);
 
                 return 0;
         }