From: Jeremy Allison <jra@samba.org>
Date: Wed, 13 Aug 2008 23:52:53 +0000 (-0700)
Subject: Fix coverity CID: 594. Resource leak on error path.
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1f38b9963c4ec0d73da496a72ba4ee74d8d581c9;p=thirdparty%2Fsamba.git

Fix coverity CID: 594. Resource leak on error path.
Jeremy.
---

diff --git a/source/rpc_server/srv_spoolss_nt.c b/source/rpc_server/srv_spoolss_nt.c
index f80240042c6..635898a9d57 100644
--- a/source/rpc_server/srv_spoolss_nt.c
+++ b/source/rpc_server/srv_spoolss_nt.c
@@ -5037,8 +5037,10 @@ static WERROR getprinter_level_7(Printer_entry *print_hnd, int snum, RPC_BUFFER
 	if((printer=SMB_MALLOC_P(PRINTER_INFO_7))==NULL)
 		return WERR_NOMEM;
 
-	if (!construct_printer_info_7(print_hnd, printer, snum))
-		return WERR_NOMEM;
+	if (!construct_printer_info_7(print_hnd, printer, snum)) {
+		result = WERR_NOMEM;
+		goto out;
+	}
 
 	/* check the required size. */
 	*needed += spoolss_size_printer_info_7(printer);