From: Andreas Schneider <asn@samba.org>
Date: Tue, 16 Jul 2019 14:13:17 +0000 (+0200)
Subject: s3:rpc_server: Only dump passwords in developer builds
X-Git-Tag: tdb-1.4.2~417
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=1f923e067dbe358c17cbccfe179baa811aa3b8b3;p=thirdparty%2Fsamba.git

s3:rpc_server: Only dump passwords in developer builds

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jul 26 03:05:01 UTC 2019 on sn-devel-184
---

diff --git a/source3/rpc_server/samr/srv_samr_nt.c b/source3/rpc_server/samr/srv_samr_nt.c
index ad1d1853bda..87214b2899e 100644
--- a/source3/rpc_server/samr/srv_samr_nt.c
+++ b/source3/rpc_server/samr/srv_samr_nt.c
@@ -5198,7 +5198,9 @@ NTSTATUS _samr_SetUserInfo(struct pipes_struct *p,
 				break;
 			}
 
+#ifdef DEBUG_PASSWORD
 			dump_data(100, info->info23.password.data, 516);
+#endif
 
 			status = set_user_info_23(p->mem_ctx,
 						  &info->info23,
@@ -5219,7 +5221,9 @@ NTSTATUS _samr_SetUserInfo(struct pipes_struct *p,
 				break;
 			}
 
+#ifdef DEBUG_PASSWORD
 			dump_data(100, info->info24.password.data, 516);
+#endif
 
 			status = set_user_info_24(p->mem_ctx,
 						  rhost,
@@ -5237,7 +5241,9 @@ NTSTATUS _samr_SetUserInfo(struct pipes_struct *p,
 				break;
 			}
 
+#ifdef DEBUG_PASSWORD
 			dump_data(100, info->info25.password.data, 532);
+#endif
 
 			status = set_user_info_25(p->mem_ctx,
 						  rhost,
@@ -5255,7 +5261,9 @@ NTSTATUS _samr_SetUserInfo(struct pipes_struct *p,
 				break;
 			}
 
+#ifdef DEBUG_PASSWORD
 			dump_data(100, info->info26.password.data, 516);
+#endif
 
 			status = set_user_info_26(p->mem_ctx,
 						  rhost,