From: Greg Kroah-Hartman Date: Tue, 1 Aug 2023 05:56:53 +0000 (+0200) Subject: 4.19-stable patches X-Git-Tag: v5.15.124~50 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=209dbb7466d72f2879cc1f753b1daf19ef8f9afb;p=thirdparty%2Fkernel%2Fstable-queue.git 4.19-stable patches added patches: virtio-net-fix-race-between-set-queues-and-probe.patch --- diff --git a/queue-4.19/series b/queue-4.19/series index 47df622f501..9aa0e6c18e4 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -275,3 +275,4 @@ tpm_tis-explicitly-check-for-error-code.patch irq-bcm6345-l1-do-not-assume-a-fixed-block-to-cpu-ma.patch serial-8250_dw-split-synopsys-designware-8250-common.patch serial-8250_dw-preserve-original-value-of-dlf-regist.patch +virtio-net-fix-race-between-set-queues-and-probe.patch diff --git a/queue-4.19/virtio-net-fix-race-between-set-queues-and-probe.patch b/queue-4.19/virtio-net-fix-race-between-set-queues-and-probe.patch new file mode 100644 index 00000000000..826f029e5cb --- /dev/null +++ b/queue-4.19/virtio-net-fix-race-between-set-queues-and-probe.patch @@ -0,0 +1,47 @@ +From 25266128fe16d5632d43ada34c847d7b8daba539 Mon Sep 17 00:00:00 2001 +From: Jason Wang +Date: Tue, 25 Jul 2023 03:20:49 -0400 +Subject: virtio-net: fix race between set queues and probe + +From: Jason Wang + +commit 25266128fe16d5632d43ada34c847d7b8daba539 upstream. + +A race were found where set_channels could be called after registering +but before virtnet_set_queues() in virtnet_probe(). Fixing this by +moving the virtnet_set_queues() before netdevice registering. While at +it, use _virtnet_set_queues() to avoid holding rtnl as the device is +not even registered at that time. + +Cc: stable@vger.kernel.org +Fixes: a220871be66f ("virtio-net: correctly enable multiqueue") +Signed-off-by: Jason Wang +Acked-by: Michael S. Tsirkin +Reviewed-by: Xuan Zhuo +Link: https://lore.kernel.org/r/20230725072049.617289-1-jasowang@redhat.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Greg Kroah-Hartman +--- + drivers/net/virtio_net.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +--- a/drivers/net/virtio_net.c ++++ b/drivers/net/virtio_net.c +@@ -3120,6 +3120,8 @@ static int virtnet_probe(struct virtio_d + } + } + ++ _virtnet_set_queues(vi, vi->curr_queue_pairs); ++ + /* serialize netdev register + virtio_device_ready() with ndo_open() */ + rtnl_lock(); + +@@ -3140,8 +3142,6 @@ static int virtnet_probe(struct virtio_d + goto free_unregister_netdev; + } + +- virtnet_set_queues(vi, vi->curr_queue_pairs); +- + /* Assume link up if device can't report link status, + otherwise get link status from config. */ + netif_carrier_off(dev);