From: Joshua Colp <jcolp@digium.com>
Date: Fri, 27 Jul 2007 16:27:16 +0000 (+0000)
Subject: (closes issue #10323)
X-Git-Tag: 1.4.10~65
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=20d0b016072afe2477d0a008197151e214c6e081;p=thirdparty%2Fasterisk.git

(closes issue #10323)
Reported by: julianjm
Patches:
      chan_sip_device_state_hold_fix.v1.diff.txt uploaded by julianjm (license 99)
Clear ONHOLD flag when decrementing the onHold peer count. If we did not do this the count may keep decreasing.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 14eee8a81b..763d0fc9b3 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -3101,8 +3101,10 @@ static int update_call_counter(struct sip_pvt *fup, int event)
 				ast_clear_flag(&fup->flags[1], SIP_PAGE2_INC_RINGING);
 			}
 		}
-		if (ast_test_flag(&fup->flags[1], SIP_PAGE2_CALL_ONHOLD) && global_notifyhold)
+		if (ast_test_flag(&fup->flags[1], SIP_PAGE2_CALL_ONHOLD) && global_notifyhold) {
+			ast_clear_flag(&fup->flags[1], SIP_PAGE2_CALL_ONHOLD);
 			sip_peer_hold(fup, 0);
+		}
 		if (option_debug > 1 || sipdebug) {
 			ast_log(LOG_DEBUG, "Call %s %s '%s' removed from call limit %d\n", outgoing ? "to" : "from", u ? "user":"peer", name, *call_limit);
 		}