From: Greg Kroah-Hartman Date: Mon, 27 Sep 2021 13:23:54 +0000 (+0200) Subject: 5.14-stable patches X-Git-Tag: v5.4.150~4 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=20ecc2627b182869312f31addcedc1582cb703d4;p=thirdparty%2Fkernel%2Fstable-queue.git 5.14-stable patches added patches: nvmet-fix-a-width-vs-precision-bug-in-nvmet_subsys_attr_serial_show.patch --- diff --git a/queue-5.14/nvmet-fix-a-width-vs-precision-bug-in-nvmet_subsys_attr_serial_show.patch b/queue-5.14/nvmet-fix-a-width-vs-precision-bug-in-nvmet_subsys_attr_serial_show.patch new file mode 100644 index 00000000000..a3e7eb24bbd --- /dev/null +++ b/queue-5.14/nvmet-fix-a-width-vs-precision-bug-in-nvmet_subsys_attr_serial_show.patch @@ -0,0 +1,33 @@ +From 0bd46e22c5ec3dbfb81b60de475151e3f6b411c2 Mon Sep 17 00:00:00 2001 +From: Dan Carpenter +Date: Thu, 9 Sep 2021 12:14:40 +0300 +Subject: nvmet: fix a width vs precision bug in nvmet_subsys_attr_serial_show() + +From: Dan Carpenter + +commit 0bd46e22c5ec3dbfb81b60de475151e3f6b411c2 upstream. + +This was intended to limit the number of characters printed from +"subsys->serial" to NVMET_SN_MAX_SIZE. But accidentally the width +specifier was used instead of the precision specifier so it only +affects the alignment and not the number of characters printed. + +Fixes: f04064814c2a ("nvmet: fixup buffer overrun in nvmet_subsys_attr_serial()") +Signed-off-by: Dan Carpenter +Signed-off-by: Christoph Hellwig +Signed-off-by: Greg Kroah-Hartman +--- + drivers/nvme/target/configfs.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/drivers/nvme/target/configfs.c ++++ b/drivers/nvme/target/configfs.c +@@ -1067,7 +1067,7 @@ static ssize_t nvmet_subsys_attr_serial_ + { + struct nvmet_subsys *subsys = to_subsys(item); + +- return snprintf(page, PAGE_SIZE, "%*s\n", ++ return snprintf(page, PAGE_SIZE, "%.*s\n", + NVMET_SN_MAX_SIZE, subsys->serial); + } + diff --git a/queue-5.14/series b/queue-5.14/series index 22c61a1d361..59cc5d8dba6 100644 --- a/queue-5.14/series +++ b/queue-5.14/series @@ -157,3 +157,4 @@ usb-serial-cp210x-fix-dropped-characters-with-cp2102.patch software-node-balance-refcount-for-managed-software-nodes.patch xen-balloon-fix-balloon-kthread-freezing.patch qnx4-work-around-gcc-false-positive-warning-bug.patch +nvmet-fix-a-width-vs-precision-bug-in-nvmet_subsys_attr_serial_show.patch