From: Rob van der Linde <rob@catalyst.net.nz>
Date: Wed, 7 Feb 2024 00:41:04 +0000 (+1300)
Subject: netcmd: models: fix build_expression on SIDField handles security.dom_sid
X-Git-Tag: tdb-1.4.11~1825
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=21667b9b512225bb74b375341e31c65dfec455a8;p=thirdparty%2Fsamba.git

netcmd: models: fix build_expression on SIDField handles security.dom_sid

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/netcmd/domain/models/fields.py b/python/samba/netcmd/domain/models/fields.py
index c02562e7c37..ab91eb84275 100644
--- a/python/samba/netcmd/domain/models/fields.py
+++ b/python/samba/netcmd/domain/models/fields.py
@@ -347,6 +347,11 @@ class SIDField(Field):
             return MessageElement(ndr_pack(security.dom_sid(value)),
                                   flags, self.name)
 
+    def expression(self, value):
+        """Returns the ldb search expression for this field."""
+        # NOTE: value can be str or `security.dom_sid` so convert to str first.
+        return f"({self.name}={binary_encode(str(value))})"
+
 
 class SDDLField(Field):
     """A SDDL field encodes and decodes SDDL data."""