From: Martin Schwenke <mschwenke@ddn.com>
Date: Thu, 29 Aug 2024 08:27:54 +0000 (+1000)
Subject: ctdb-server: Clean up find_public_ip_vnn()
X-Git-Tag: tdb-1.4.13~984
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2167261b0e536fa04bcc05a3f3ecea9aa6b18a05;p=thirdparty%2Fsamba.git

ctdb-server: Clean up find_public_ip_vnn()

Fix the comment (NULL versus -1), apply some README.Coding.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/ctdb/server/ctdb_takeover.c b/ctdb/server/ctdb_takeover.c
index ccd9a92e4fe..4e2cff27a1f 100644
--- a/ctdb/server/ctdb_takeover.c
+++ b/ctdb/server/ctdb_takeover.c
@@ -719,14 +719,14 @@ static int32_t ctdb_do_updateip(struct ctdb_context *ctdb,
 }
 
 /*
-  Find the vnn of the node that has a public ip address
-  returns -1 if the address is not known as a public address
+ * Find vnn that has public IP addr, return NULL if not found
  */
-static struct ctdb_vnn *find_public_ip_vnn(struct ctdb_context *ctdb, ctdb_sock_addr *addr)
+static struct ctdb_vnn *find_public_ip_vnn(struct ctdb_context *ctdb,
+					   ctdb_sock_addr *addr)
 {
-	struct ctdb_vnn *vnn;
+	struct ctdb_vnn *vnn = NULL;
 
-	for (vnn=ctdb->vnn;vnn;vnn=vnn->next) {
+	for (vnn = ctdb->vnn; vnn != NULL; vnn = vnn->next) {
 		if (ctdb_same_ip(&vnn->public_address, addr)) {
 			return vnn;
 		}