From: Ralph Boehme <slow@samba.org>
Date: Fri, 16 Feb 2024 15:42:59 +0000 (+0100)
Subject: winbindd: properly initialize sid and type in wb_cache_name_to_sid()
X-Git-Tag: tdb-1.4.11~54
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=21b9eb5b8c14bf0a5255f8e5897a214e004e32e1;p=thirdparty%2Fsamba.git

winbindd: properly initialize sid and type in wb_cache_name_to_sid()

No change in behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
index 22817388e87..22a23f5a4b2 100644
--- a/source3/winbindd/winbindd_cache.c
+++ b/source3/winbindd/winbindd_cache.c
@@ -1824,13 +1824,14 @@ NTSTATUS wb_cache_name_to_sid(struct winbindd_domain *domain,
 
 	was_online = domain->online;
 
+	ZERO_STRUCTP(sid);
+	*type = SID_NAME_UNKNOWN;
+
 	status = wcache_name_to_sid(domain, domain_name, name, sid, type);
 	if (!NT_STATUS_EQUAL(status, NT_STATUS_NOT_FOUND)) {
 		return status;
 	}
 
-	ZERO_STRUCTP(sid);
-
 	DBG_DEBUG("name_to_sid: [Cached] - doing backend query for name for domain %s\n",
 		domain->name );