From: Rafael J. Wysocki Date: Mon, 1 Jun 2026 16:56:33 +0000 (+0200) Subject: ACPI: button: Improve warning message regarding lid state X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=21d822d603ab2a84211651aa39b65e6118add51b;p=thirdparty%2Fkernel%2Flinux.git ACPI: button: Improve warning message regarding lid state The warning message regarding an unexpected lid state printed by acpi_lid_notify_state() is quite cryptic and there is no information in it to indicate that it is about a platform firmware defect. In fact, it can only be understood after reading the comment below the statement printing it. For this reason, replace it with a more direct one including FW_BUG so its connection to a firmware issue is clearer. While at it, fix up a comment preceding the statement printing the message in question. Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/5084775.GXAFRqVoOG@rafael.j.wysocki --- diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index 0b96db762bea2..d2c2b81056391 100644 --- a/drivers/acpi/button.c +++ b/drivers/acpi/button.c @@ -227,8 +227,8 @@ static int acpi_lid_notify_state(struct acpi_button *button, int state) ms_to_ktime(lid_report_interval)); if (button->last_state == !!state && ktime_after(ktime_get(), next_report)) { - /* Complain the buggy firmware */ - pr_warn_once("The lid device is not compliant to SW_LID.\n"); + /* Complain about the buggy firmware. */ + pr_warn_once(FW_BUG "Unexpected lid state reported by firmware\n"); /* * Send the unreliable complement switch event: