From: Victor Stinner Date: Mon, 4 Nov 2013 10:28:26 +0000 (+0100) Subject: Issue #19424: PyUnicode_CompareWithASCIIString() normalizes memcmp() result X-Git-Tag: v3.4.0b1~398 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=21ea21ef6db731a8cac14fcd0c1a12c5c44496f4;p=thirdparty%2FPython%2Fcpython.git Issue #19424: PyUnicode_CompareWithASCIIString() normalizes memcmp() result to -1, 0, 1 --- diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 154103dfea31..574b57a259f2 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -10584,8 +10584,12 @@ PyUnicode_CompareWithASCIIString(PyObject* uni, const char* str) len = Py_MIN(len1, len2); cmp = memcmp(data, str, len); - if (cmp != 0) - return cmp; + if (cmp != 0) { + if (cmp < 0) + return -1; + else + return 1; + } if (len1 > len2) return 1; /* uni is longer */ if (len2 > len1)