From: Jeremy Allison <jra@samba.org>
Date: Mon, 14 Jan 2008 19:06:46 +0000 (-0800)
Subject: From Alexander Bokovoy
X-Git-Tag: samba-3.2.0pre2~38^2^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=22a4129fabf70e01cc638c2f7347c28201838830;p=thirdparty%2Fsamba.git

From Alexander Bokovoy

names is a 'const char **names' here, passed from upper level. Passing
'names' as a talloc context will break things as 'names' is usually
likely is a local variable, not a talloc'd. And we want to have array
elements on a context of the array anyway.

Jeremy.
---

diff --git a/source/lib/winbind_util.c b/source/lib/winbind_util.c
index 3cf068a6e0d..14356b09cf7 100644
--- a/source/lib/winbind_util.c
+++ b/source/lib/winbind_util.c
@@ -201,7 +201,7 @@ bool winbind_lookup_rids(TALLOC_CTX *mem_ctx,
 	*types       = TALLOC_ARRAY(mem_ctx, enum lsa_SidType, num_rids);
 
 	for(i=0; i<num_rids; i++) {
-		(*names)[i] = talloc_strdup(names, namelist[i]);
+		(*names)[i] = talloc_strdup(*names, namelist[i]);
 		(*types)[i] = (enum lsa_SidType)name_types[i];
 	}