From: Tomas Mraz <tomas@openssl.org>
Date: Tue, 2 Mar 2021 15:55:48 +0000 (+0100)
Subject: do_sigver_init: Remove fallback for missing provider implementations.
X-Git-Tag: openssl-3.0.0-alpha13~54
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=22cd04143b2cd21f3285369659e98617dd0a482d;p=thirdparty%2Fopenssl.git

do_sigver_init: Remove fallback for missing provider implementations.

We now have everything implemented in providers.

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14404)
---

diff --git a/crypto/evp/m_sigver.c b/crypto/evp/m_sigver.c
index 795b7859837..7650512d2a8 100644
--- a/crypto/evp/m_sigver.c
+++ b/crypto/evp/m_sigver.c
@@ -90,17 +90,6 @@ static int do_sigver_init(EVP_MD_CTX *ctx, EVP_PKEY_CTX **pctx,
     provkey = evp_pkey_export_to_provider(locpctx->pkey, locpctx->libctx,
                                           &tmp_keymgmt, locpctx->propquery);
     if (provkey == NULL) {
-        /*
-         * If we couldn't find a keymgmt at all try legacy.
-         * TODO(3.0): Once all legacy algorithms (SM2, HMAC etc) have provider
-         * based implementations this fallback shouldn't be necessary. Either
-         * we have an ENGINE based implementation (in which case we should have
-         * already fallen back in the test above here), or we don't have the
-         * provider based implementation loaded (in which case this is an
-         * application config error)
-         */
-        if (locpctx->keymgmt == NULL)
-            goto legacy;
         ERR_raise(ERR_LIB_EVP, EVP_R_INITIALIZATION_ERROR);
         goto err;
     }