From: Jan Hubicka Date: Wed, 2 Jul 2014 15:23:56 +0000 (+0200) Subject: c-decl.c (duplicate_decls): CLear DECL_STRUCT_FUNCTION before releasing symbol. X-Git-Tag: releases/gcc-5.1.0~6524 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=22e1cf1ced6f9e72cf7d4dad64747b8303221fda;p=thirdparty%2Fgcc.git c-decl.c (duplicate_decls): CLear DECL_STRUCT_FUNCTION before releasing symbol. * c-decl.c (duplicate_decls): CLear DECL_STRUCT_FUNCTION before releasing symbol. * gcc.c-torture/compile/section.c: New testcase. Co-Authored-By: Chen Gang From-SVN: r212234 --- diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog index 1c1936245d86..68abca4dfb1e 100644 --- a/gcc/c/ChangeLog +++ b/gcc/c/ChangeLog @@ -1,3 +1,9 @@ +2014-07-02 Jan Hubicka + Chen Gang + + * c-decl.c (duplicate_decls): CLear DECL_STRUCT_FUNCTION before + releasing symbol. + 2014-07-01 Marek Polacek * c-typeck.c (convert_for_assignment): Pass OPT_Wint_conversion diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c index 7c37edfd3728..3dec90b23ed5 100644 --- a/gcc/c/c-decl.c +++ b/gcc/c/c-decl.c @@ -2575,7 +2575,14 @@ duplicate_decls (tree newdecl, tree olddecl) merge_decls (newdecl, olddecl, newtype, oldtype); - /* The NEWDECL will no longer be needed. */ + /* The NEWDECL will no longer be needed. + + Before releasing the node, be sure to remove function from symbol + table that might have been inserted there to record comdat group. + Be sure to however do not free DECL_STRUCT_FUNCTION because this + structure is shared in between NEWDECL and OLDECL. */ + if (TREE_CODE (newdecl) == FUNCTION_DECL) + DECL_STRUCT_FUNCTION (newdecl) = NULL; if (TREE_CODE (newdecl) == FUNCTION_DECL || TREE_CODE (newdecl) == VAR_DECL) { diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 1195959ff2d1..286898309fa2 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-07-02 Jan Hubicka + Chen Gang + + * gcc.c-torture/compile/section.c: New testcase. + 2014-07-02 Christian Bruel PR target/29349 diff --git a/gcc/testsuite/gcc.c-torture/compile/section.c b/gcc/testsuite/gcc.c-torture/compile/section.c new file mode 100644 index 000000000000..1e8d094068c6 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/section.c @@ -0,0 +1,8 @@ +/* { dg-do compile } */ + +/* { dg-require-effective-target named_sections } */ +extern int __attribute__ ((__section__(".init.text"))) elv_register(void) +{ + return 0; +} +extern typeof(elv_register) elv_register;