From: stratakis Date: Wed, 17 Jun 2020 17:26:08 +0000 (+0200) Subject: bpo-40637: Do not emit warnings for disabled builtin hashes (GH-20937) X-Git-Tag: v3.10.0a1~595 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=236a0f5cf022b59dbb6ea17a8e7a677c573d39b9;p=thirdparty%2FPython%2Fcpython.git bpo-40637: Do not emit warnings for disabled builtin hashes (GH-20937) test_hashlib emits some warnings when it cannot find some hashes as it assumes they failed to compile. Since we can disable hashes through configure, we emit the warnings only in the case that we did not intentionaly disable them. Automerge-Triggered-By: @tiran --- diff --git a/Lib/test/test_hashlib.py b/Lib/test/test_hashlib.py index 2f79244748e6..ba902986adb8 100644 --- a/Lib/test/test_hashlib.py +++ b/Lib/test/test_hashlib.py @@ -103,7 +103,7 @@ class HashLibTestCase(unittest.TestCase): try: return importlib.import_module(module_name) except ModuleNotFoundError as error: - if self._warn_on_extension_import: + if self._warn_on_extension_import and module_name in builtin_hashes: warnings.warn('Did a C extension fail to compile? %s' % error) return None