From: Victor Stinner <victor.stinner@gmail.com>
Date: Mon, 18 Nov 2013 17:35:55 +0000 (+0100)
Subject: Issue #19437: Fix error handling of CDataType_from_buffer()
X-Git-Tag: v3.4.0b1~196
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2399ad51d435495636106ce2695712499983a715;p=thirdparty%2FPython%2Fcpython.git

Issue #19437: Fix error handling of CDataType_from_buffer()

KeepRef() decreases the reference counter of its 'keep' parameter on error
---

diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
index f47dbdf1ff47..be0f33a69e9f 100644
--- a/Modules/_ctypes/_ctypes.c
+++ b/Modules/_ctypes/_ctypes.c
@@ -454,7 +454,6 @@ CDataType_from_buffer(PyObject *type, PyObject *args)
 
     Py_INCREF(obj);
     if (-1 == KeepRef((CDataObject *)result, -1, obj)) {
-        Py_DECREF(result);
         return NULL;
     }
     return result;