From: Viktor Szakats <commit@vsz.me>
Date: Mon, 27 Jan 2025 14:43:32 +0000 (+0100)
Subject: msvc: add missing push/pop for warning pragmas
X-Git-Tag: curl-8_12_0~37
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=23b41224e3e0c53a1fb059ec66e5d3e2c80f717d;p=thirdparty%2Fcurl.git

msvc: add missing push/pop for warning pragmas

Also fix indentation/formatting around similar pragmas.

Closes #16101
---

diff --git a/lib/ftp.c b/lib/ftp.c
index 4b52773817..cb0fada0c7 100644
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -4108,8 +4108,8 @@ static CURLcode ftp_disconnect(struct Curl_easy *data,
 }
 
 #ifdef _MSC_VER
-/* warning C4706: assignment within conditional expression */
-#pragma warning(disable:4706)
+#pragma warning(push)
+#pragma warning(disable:4706) /* assignment within conditional expression */
 #endif
 
 /***********************************************************************
@@ -4266,6 +4266,10 @@ CURLcode ftp_parse_url_path(struct Curl_easy *data)
   return CURLE_OK;
 }
 
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
+
 /* call this when the DO phase has completed */
 static CURLcode ftp_dophase_done(struct Curl_easy *data, bool connected)
 {
diff --git a/lib/ldap.c b/lib/ldap.c
index 4eeb013070..0fa304bdf8 100644
--- a/lib/ldap.c
+++ b/lib/ldap.c
@@ -57,7 +57,7 @@
 #ifdef USE_WIN32_LDAP           /* Use Windows LDAP implementation. */
 # ifdef _MSC_VER
 #  pragma warning(push)
-#  pragma warning(disable: 4201)
+#  pragma warning(disable:4201)
 # endif
 # include <subauth.h>  /* for [P]UNICODE_STRING */
 # ifdef _MSC_VER
diff --git a/lib/telnet.c b/lib/telnet.c
index b75320f613..589f9dab49 100644
--- a/lib/telnet.c
+++ b/lib/telnet.c
@@ -779,8 +779,7 @@ static void printsub(struct Curl_easy *data,
 
 #ifdef _MSC_VER
 #pragma warning(push)
-/* warning C4706: assignment within conditional expression */
-#pragma warning(disable:4706)
+#pragma warning(disable:4706) /* assignment within conditional expression */
 #endif
 static bool str_is_nonascii(const char *str)
 {
diff --git a/lib/vtls/schannel.h b/lib/vtls/schannel.h
index b26334bcf8..69f1baddb8 100644
--- a/lib/vtls/schannel.h
+++ b/lib/vtls/schannel.h
@@ -30,7 +30,7 @@
 
 #ifdef _MSC_VER
 #pragma warning(push)
-#pragma warning(disable: 4201)
+#pragma warning(disable:4201)
 #endif
 #include <subauth.h>
 #ifdef _MSC_VER
diff --git a/lib/warnless.c b/lib/warnless.c
index b44119516b..41699600be 100644
--- a/lib/warnless.c
+++ b/lib/warnless.c
@@ -126,8 +126,8 @@ int curlx_uztosi(size_t uznum)
 unsigned long curlx_uztoul(size_t uznum)
 {
 #ifdef __INTEL_COMPILER
-# pragma warning(push)
-# pragma warning(disable:810) /* conversion may lose significant bits */
+#  pragma warning(push)
+#  pragma warning(disable:810) /* conversion may lose significant bits */
 #endif
 
 #if ULONG_MAX < SIZE_T_MAX
@@ -136,7 +136,7 @@ unsigned long curlx_uztoul(size_t uznum)
   return (unsigned long)(uznum & (size_t) CURL_MASK_ULONG);
 
 #ifdef __INTEL_COMPILER
-# pragma warning(pop)
+#  pragma warning(pop)
 #endif
 }
 
@@ -147,8 +147,8 @@ unsigned long curlx_uztoul(size_t uznum)
 unsigned int curlx_uztoui(size_t uznum)
 {
 #ifdef __INTEL_COMPILER
-# pragma warning(push)
-# pragma warning(disable:810) /* conversion may lose significant bits */
+#  pragma warning(push)
+#  pragma warning(disable:810) /* conversion may lose significant bits */
 #endif
 
 #if UINT_MAX < SIZE_T_MAX
@@ -157,7 +157,7 @@ unsigned int curlx_uztoui(size_t uznum)
   return (unsigned int)(uznum & (size_t) CURL_MASK_UINT);
 
 #ifdef __INTEL_COMPILER
-# pragma warning(pop)
+#  pragma warning(pop)
 #endif
 }
 
diff --git a/src/tool_writeout_json.c b/src/tool_writeout_json.c
index 205b702ae1..d85243b51a 100644
--- a/src/tool_writeout_json.c
+++ b/src/tool_writeout_json.c
@@ -119,8 +119,8 @@ void ourWriteOutJSON(FILE *stream, const struct writeoutvar mappings[],
 }
 
 #ifdef _MSC_VER
-/* warning C4706: assignment within conditional expression */
-#pragma warning(disable:4706)
+#pragma warning(push)
+#pragma warning(disable:4706) /* assignment within conditional expression */
 #endif
 
 void headerJSON(FILE *stream, struct per_transfer *per)
@@ -169,3 +169,7 @@ void headerJSON(FILE *stream, struct per_transfer *per)
   }
   fputs("\n}", stream);
 }
+
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
diff --git a/tests/libtest/lib1945.c b/tests/libtest/lib1945.c
index 8cbb01ec6c..59db5540f3 100644
--- a/tests/libtest/lib1945.c
+++ b/tests/libtest/lib1945.c
@@ -27,8 +27,8 @@
 #include "memdebug.h"
 
 #ifdef _MSC_VER
-/* warning C4706: assignment within conditional expression */
-#pragma warning(disable:4706)
+#pragma warning(push)
+#pragma warning(disable:4706) /* assignment within conditional expression */
 #endif
 static void showem(CURL *easy, unsigned int type)
 {
@@ -41,6 +41,9 @@ static void showem(CURL *easy, unsigned int type)
     prev = header;
   }
 }
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 
 static size_t write_cb(char *data, size_t n, size_t l, void *userp)
 {