From: Andreas Schneider <asn@samba.org>
Date: Thu, 24 Feb 2022 10:41:14 +0000 (+0100)
Subject: s3:script: Fix shellcheck errors in test_dfree_quota.sh
X-Git-Tag: talloc-2.4.0~1379
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=249b8e8af8c20f28005cdd56deda919aaddaec05;p=thirdparty%2Fsamba.git

s3:script: Fix shellcheck errors in test_dfree_quota.sh

source3/script/tests/test_dfree_quota.sh:125:65: error: Double quote
array expansions to avoid re-splitting elements. [SC2068]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
---

diff --git a/source3/script/tests/test_dfree_quota.sh b/source3/script/tests/test_dfree_quota.sh
index e14f6349201..bd036184c33 100755
--- a/source3/script/tests/test_dfree_quota.sh
+++ b/source3/script/tests/test_dfree_quota.sh
@@ -122,7 +122,7 @@ test_smbclient_dfree()
 	shift
 	subunit_start_test "$name"
 	setup_conf $confs
-	output=$($VALGRIND $smbclient //$SERVER/$share -c "cd $dir; l" $@ 2>&1)
+	output=$($VALGRIND $smbclient //$SERVER/$share -c "cd $dir; l" "$@" 2>&1)
 	status=$?
 	if [ "$status" = "0" ]; then
 		received=$(echo "$output" | awk '/blocks of size/ {print $1, $5, $6}')
@@ -150,7 +150,7 @@ test_smbclient_dfree_2()
 	subunit_start_test "$name"
 	setup_conf $confs
 	output=$($VALGRIND $smbclient //$SERVER/$share \
-		-c "cd $dir1; du; cd ..; cd $dir2 ; du" $@ 2>&1)
+		-c "cd $dir1; du; cd ..; cd $dir2 ; du" "$@" 2>&1)
 	status=$?
 	if [ "$status" = "0" ]; then
 		received=$(echo "$output" |
@@ -187,7 +187,7 @@ test_smbcquotas()
 		mproto="-m SMB1"
 	fi
 
-	output=$($VALGRIND $smbcquotas $mproto //$SERVER/dfq $@ 2>/dev/null | tr '\\' '/')
+	output=$($VALGRIND $smbcquotas $mproto //$SERVER/dfq "$@" 2>/dev/null | tr '\\' '/')
 	status=$?
 	if [ "$status" = "0" ]; then
 		received=$(echo "$output" | awk "/$SERVER\\/$user/ {printf \"%s%s%s\", \$3, \$4, \$5}")