From: Volker Lendecke <vl@samba.org>
Date: Thu, 28 Nov 2024 08:47:20 +0000 (+0100)
Subject: libcli: Avoid an unnecessary "else"
X-Git-Tag: tdb-1.4.13~428
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=24ef76e96034c7d6647c9afb50d384365bdb4660;p=thirdparty%2Fsamba.git

libcli: Avoid an unnecessary "else"

We return in the error case anyway

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/libcli/security/sddl_conditional_ace.c b/libcli/security/sddl_conditional_ace.c
index 62323a300a0..0d2d4d041dc 100644
--- a/libcli/security/sddl_conditional_ace.c
+++ b/libcli/security/sddl_conditional_ace.c
@@ -2053,9 +2053,8 @@ static bool parse_sid(struct ace_condition_sddl_compiler_context *comp)
 	    comp->sddl[comp->offset + 3] != '(') {
 		comp_error(comp, "malformed SID() constructor");
 		return false;
-	} else {
-		comp->offset += 4;
 	}
+	comp->offset += 4;
 
 	sidstr = comp->sddl + comp->offset;