From: Pablo Galindo <Pablogsal@gmail.com>
Date: Wed, 4 Dec 2019 09:29:10 +0000 (+0000)
Subject: bpo-38962: Fix reference leak in test_httpservers (GH-17454)
X-Git-Tag: v3.9.0a2~87
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=24f5cac7254177a4c9956d680c0a9b6dadd85c6f;p=thirdparty%2FPython%2Fcpython.git

bpo-38962: Fix reference leak in test_httpservers (GH-17454)
---

diff --git a/Lib/test/test_httpservers.py b/Lib/test/test_httpservers.py
index 26da71e0b270..c442f5571a86 100644
--- a/Lib/test/test_httpservers.py
+++ b/Lib/test/test_httpservers.py
@@ -807,11 +807,15 @@ class CGIHTTPServerTestCase(BaseTestCase):
             (res.read(), res.getheader('Content-type'), res.status))
 
     def test_cgi_path_in_sub_directories(self):
-        CGIHTTPRequestHandler.cgi_directories.append('/sub/dir/cgi-bin')
-        res = self.request('/sub/dir/cgi-bin/file5.py')
-        self.assertEqual(
-            (b'Hello World' + self.linesep, 'text/html', HTTPStatus.OK),
-            (res.read(), res.getheader('Content-type'), res.status))
+        try:
+            CGIHTTPRequestHandler.cgi_directories.append('/sub/dir/cgi-bin')
+            res = self.request('/sub/dir/cgi-bin/file5.py')
+            self.assertEqual(
+                (b'Hello World' + self.linesep, 'text/html', HTTPStatus.OK),
+                (res.read(), res.getheader('Content-type'), res.status))
+        finally:
+            CGIHTTPRequestHandler.cgi_directories.remove('/sub/dir/cgi-bin')
+
 
 
 class SocketlessRequestHandler(SimpleHTTPRequestHandler):