From: Florian Krohm Date: Sat, 24 Jan 2015 18:26:05 +0000 (+0000) Subject: Followup to r14886. So it turned out that in m_addrinfo we were already X-Git-Tag: svn/VALGRIND_3_11_0~705 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=250c96dd89f5a7abd94dd761d1eca4bb739d7cc9;p=thirdparty%2Fvalgrind.git Followup to r14886. So it turned out that in m_addrinfo we were already strduping the filename which I failed to spot. Thanks to Philippe for pointing that out. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14887 --- diff --git a/coregrind/m_addrinfo.c b/coregrind/m_addrinfo.c index 7fc777bc40..0be05667da 100644 --- a/coregrind/m_addrinfo.c +++ b/coregrind/m_addrinfo.c @@ -295,10 +295,6 @@ void VG_(describe_addr) ( Addr a, /*OUT*/AddrInfo* ai ) if (seg->kind == SkFileC) ai->Addr.SegmentKind.filename = VG_(strdup)("mc.da.skfname", VG_(am_get_filename)(seg)); - if (ai->Addr.SegmentKind.filename != NULL) - ai->Addr.SegmentKind.filename - = VG_(strdup)("mc.da.skfname", - ai->Addr.SegmentKind.filename); ai->Addr.SegmentKind.hasR = seg->hasR; ai->Addr.SegmentKind.hasW = seg->hasW; ai->Addr.SegmentKind.hasX = seg->hasX;