From: Victor Stinner <vstinner@python.org>
Date: Fri, 24 Apr 2020 00:43:18 +0000 (+0200)
Subject: bpo-40048: Fix _PyCode_InitOpcache() error path (GH-19691)
X-Git-Tag: v3.9.0a6~23
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=25104949a5a60ff86c10691e184ce2ecb500159b;p=thirdparty%2FPython%2Fcpython.git

bpo-40048: Fix _PyCode_InitOpcache() error path (GH-19691)

If _PyCode_InitOpcache() fails in _PyEval_EvalFrameDefault(), use
"goto exit_eval_frame;" rather than "return NULL;" to exit the
function in a consistent state. For example, tstate->frame is now
reset properly.
---

diff --git a/Python/ceval.c b/Python/ceval.c
index 59765d850ba1..c610419f24f5 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -1297,7 +1297,7 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, PyFrameObject *f, int throwflag)
         co->co_opcache_flag++;
         if (co->co_opcache_flag == OPCACHE_MIN_RUNS) {
             if (_PyCode_InitOpcache(co) < 0) {
-                return NULL;
+                goto exit_eval_frame;
             }
 #if OPCACHE_STATS
             opcache_code_objects_extra_mem +=