From: Victor Stinner <victor.stinner@gmail.com>
Date: Tue, 26 Jan 2016 23:37:59 +0000 (+0100)
Subject: Issue #26146: remove useless code
X-Git-Tag: v3.6.0a1~693
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=25219f596a069e8d4ed7114cd9b1bddc2a1de3b7;p=thirdparty%2FPython%2Fcpython.git

Issue #26146: remove useless code

obj2ast_constant() code is baesd on obj2ast_object() which has a special case
for Py_None. But in practice, we don't need to have a special case for
constants.

Issue noticed by Joseph Jevnik on a review.
---

diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
index a81644d3b229..17c85173f139 100644
--- a/Parser/asdl_c.py
+++ b/Parser/asdl_c.py
@@ -874,13 +874,6 @@ static int obj2ast_object(PyObject* obj, PyObject** out, PyArena* arena)
 
 static int obj2ast_constant(PyObject* obj, PyObject** out, PyArena* arena)
 {
-    if (obj == Py_None || obj == Py_True || obj == Py_False) {
-        /* don't increment the reference counter, Constant uses a borrowed
-         * reference, not a strong reference */
-        *out = obj;
-        return 0;
-    }
-
     if (obj) {
         if (PyArena_AddPyObject(arena, obj) < 0) {
             *out = NULL;
diff --git a/Python/Python-ast.c b/Python/Python-ast.c
index 4dde11f00c18..1193c7c66bea 100644
--- a/Python/Python-ast.c
+++ b/Python/Python-ast.c
@@ -753,13 +753,6 @@ static int obj2ast_object(PyObject* obj, PyObject** out, PyArena* arena)
 
 static int obj2ast_constant(PyObject* obj, PyObject** out, PyArena* arena)
 {
-    if (obj == Py_None || obj == Py_True || obj == Py_False) {
-        /* don't increment the reference counter, Constant uses a borrowed
-         * reference, not a strong reference */
-        *out = obj;
-        return 0;
-    }
-
     if (obj) {
         if (PyArena_AddPyObject(arena, obj) < 0) {
             *out = NULL;