From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Mon, 20 Apr 2026 22:03:20 +0000 (+0200)
Subject: efi_loader: correct efi_binary_run_dp() return value
X-Git-Tag: v2026.07-rc2~31^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=257f9f52738641f8981b3ccb17d56567d145a084;p=thirdparty%2Fu-boot.git

efi_loader: correct efi_binary_run_dp() return value

efi_binary_run_dp() is expected to return an efi_status_t value.

Reported-by: Simon Glass <sjg@chromium.org>
Fixes: 6422820ac3e5 ("efi_loader: split unrelated code from efi_bootmgr.c")
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---

diff --git a/lib/efi_loader/efi_bootbin.c b/lib/efi_loader/efi_bootbin.c
index b394f0d60ce..144266b785f 100644
--- a/lib/efi_loader/efi_bootbin.c
+++ b/lib/efi_loader/efi_bootbin.c
@@ -227,7 +227,7 @@ static efi_status_t efi_binary_run_dp(void *image, size_t size, void *fdt,
 	if (ret != EFI_SUCCESS) {
 		log_err("Error: Cannot initialize UEFI sub-system, r = %lu\n",
 			ret & ~EFI_ERROR_MASK);
-		return -1;
+		return ret;
 	}
 
 	ret = efi_install_fdt(fdt);