From: Noel Power Date: Tue, 13 Aug 2019 14:27:35 +0000 (+0100) Subject: s3/libsmb: clang: Fix 'Dereference of undefined pointer value' X-Git-Tag: talloc-2.3.1~271 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=25a256bedf2992771b6ea1263fb5e730b27a53dc;p=thirdparty%2Fsamba.git s3/libsmb: clang: Fix 'Dereference of undefined pointer value' Fixes: source3/libsmb/clidfs.c:350:3: warning: Dereference of undefined pointer value <--[clang] DLIST_ADD_END(referring_cli, cli); ^ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Ralph Boehme --- diff --git a/source3/libsmb/clidfs.c b/source3/libsmb/clidfs.c index f617307bb03..ba851f3f471 100644 --- a/source3/libsmb/clidfs.c +++ b/source3/libsmb/clidfs.c @@ -333,7 +333,7 @@ static NTSTATUS cli_cm_connect(TALLOC_CTX *ctx, int name_type, struct cli_state **pcli) { - struct cli_state *cli; + struct cli_state *cli = NULL; NTSTATUS status; status = do_connect(ctx, server, share, @@ -345,6 +345,14 @@ static NTSTATUS cli_cm_connect(TALLOC_CTX *ctx, return status; } + /* + * This can't happen, this test is to satisfy static + * checkers (clang) + */ + if (cli == NULL) { + return NT_STATUS_NO_MEMORY; + } + /* Enter into the list. */ if (referring_cli) { DLIST_ADD_END(referring_cli, cli);