From: Nikita Sobolev <mail@sobolevn.me>
Date: Mon, 6 Feb 2023 21:05:41 +0000 (+0300)
Subject: gh-101609: Fix "‘state’ may be used uninitialized" warning in `_xxinterpchannelsmodul... 
X-Git-Tag: v3.12.0a5~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=262003fd3297f7f4ee09cebd1abb225066412ce7;p=thirdparty%2FPython%2Fcpython.git

gh-101609: Fix "‘state’ may be used uninitialized" warning in `_xxinterpchannelsmodule` (GH-101610)



I went with the easiest solution: just removing the offending line. See the issue description with my reasoning.

https://github.com/python/cpython/issues/101609
---

diff --git a/Modules/_xxinterpchannelsmodule.c b/Modules/_xxinterpchannelsmodule.c
index 8601a189e875..60538c318748 100644
--- a/Modules/_xxinterpchannelsmodule.c
+++ b/Modules/_xxinterpchannelsmodule.c
@@ -174,7 +174,9 @@ static int
 clear_module_state(module_state *state)
 {
     /* heap types */
-    (void)_PyCrossInterpreterData_UnregisterClass(state->ChannelIDType);
+    if (state->ChannelIDType != NULL) {
+        (void)_PyCrossInterpreterData_UnregisterClass(state->ChannelIDType);
+    }
     Py_CLEAR(state->ChannelIDType);
 
     /* exceptions */
@@ -2269,7 +2271,6 @@ module_exec(PyObject *mod)
     return 0;
 
 error:
-    (void)_PyCrossInterpreterData_UnregisterClass(state->ChannelIDType);
     _globals_fini();
     return -1;
 }