From: Zijun Hu Date: Sun, 9 Feb 2025 12:58:58 +0000 (+0800) Subject: of/irq: Fix device node refcount leakages in of_irq_count() X-Git-Tag: v5.10.237~194 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=26216f43c0c9837a7209d24644e6fe9253de2a01;p=thirdparty%2Fkernel%2Fstable.git of/irq: Fix device node refcount leakages in of_irq_count() commit bbf71f44aaf241d853759a71de7e7ebcdb89be3d upstream. of_irq_count() invokes of_irq_parse_one() to count IRQs, and successful invocation of the later will get device node @irq.np refcount, but the former does not put the refcount before next iteration invocation, hence causes device node refcount leakages. Fix by putting @irq.np refcount before the next iteration invocation. Fixes: 3da5278727a8 ("of/irq: Rework of_irq_count()") Cc: stable@vger.kernel.org Signed-off-by: Zijun Hu Link: https://lore.kernel.org/r/20250209-of_irq_fix-v2-5-93e3a2659aa7@quicinc.com Signed-off-by: Rob Herring (Arm) Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/of/irq.c b/drivers/of/irq.c index ddb3ed0483d94..ddaf5ac544b0e 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -443,8 +443,10 @@ int of_irq_count(struct device_node *dev) struct of_phandle_args irq; int nr = 0; - while (of_irq_parse_one(dev, nr, &irq) == 0) + while (of_irq_parse_one(dev, nr, &irq) == 0) { + of_node_put(irq.np); nr++; + } return nr; }