From: Luca Boccassi <luca.boccassi@microsoft.com>
Date: Wed, 7 Apr 2021 09:15:20 +0000 (+0100)
Subject: coredump: use set_put_strdup()
X-Git-Tag: v249-rc1~463^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=26c22c84e0d99e645057e7c77e36dbdb606c1e27;p=thirdparty%2Fsystemd.git

coredump: use set_put_strdup()

Follow-up for 95f71807733
---

diff --git a/src/coredump/stacktrace.c b/src/coredump/stacktrace.c
index b37f02b21e8..cc31c7b03cf 100644
--- a/src/coredump/stacktrace.c
+++ b/src/coredump/stacktrace.c
@@ -166,7 +166,6 @@ static int parse_package_metadata(const char *name, JsonVariant *id_json, Elf *e
                          * magic ID is always the same. */
                         if (note_header.n_type == ELF_PACKAGE_METADATA_ID) {
                                 _cleanup_(json_variant_unrefp) JsonVariant *v = NULL, *w = NULL;
-                                char *name_key = NULL;
 
                                 r = json_parse(payload, 0, &v, NULL, NULL);
                                 if (r < 0) {
@@ -206,14 +205,9 @@ static int parse_package_metadata(const char *name, JsonVariant *id_json, Elf *e
                                 }
 
                                 /* Finally stash the name, so we avoid double visits. */
-                                name_key = strdup(name);
-                                if (!name_key) {
-                                        log_oom();
-                                        return DWARF_CB_ABORT;
-                                }
-                                r = set_ensure_consume(c->modules, &string_hash_ops, name_key);
+                                r = set_put_strdup(c->modules, name);
                                 if (r < 0) {
-                                        log_error_errno(r, "set_ensure_consume failed: %m");
+                                        log_error_errno(r, "set_put_strdup failed: %m");
                                         return DWARF_CB_ABORT;
                                 }