From: Pablo Galindo <Pablogsal@gmail.com>
Date: Sun, 12 May 2019 00:43:04 +0000 (+0100)
Subject: bpo-36817: Do not decrement reference for expr_text on fstring = parsing failure... 
X-Git-Tag: v3.8.0b1~404
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=26f55c29f2316648939ad12a9d3730a2118da2ea;p=thirdparty%2FPython%2Fcpython.git

bpo-36817: Do not decrement reference for expr_text on fstring = parsing failure (GH-13256)
---

diff --git a/Lib/test/test_fstring.py b/Lib/test/test_fstring.py
index a0fae50d1720..3484fcecf1c5 100644
--- a/Lib/test/test_fstring.py
+++ b/Lib/test/test_fstring.py
@@ -1148,6 +1148,8 @@ non-important content
         self.assertEqual(f'{C()=:x}', 'C()=FORMAT-x')
         self.assertEqual(f'{C()=!r:*^20}', 'C()=********REPR********')
 
+        self.assertRaises(SyntaxError, eval, "f'{C=]'")
+
     def test_walrus(self):
         x = 20
         # This isn't an assignment expression, it's 'x', with a format
diff --git a/Python/ast.c b/Python/ast.c
index 585f8b3fba4c..03da4e7f7f9a 100644
--- a/Python/ast.c
+++ b/Python/ast.c
@@ -5283,7 +5283,6 @@ unexpected_end_of_string:
     /* Falls through to error. */
 
 error:
-    Py_XDECREF(expr_text);
     return -1;
 
 }