From: Su Hui Date: Mon, 20 Nov 2023 09:55:23 +0000 (+0800) Subject: misc: mei: client.c: return negative error code in mei_cl_write X-Git-Tag: v5.15.143~40 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=271b563063e394f92e7d612b0dd665005fad5e95;p=thirdparty%2Fkernel%2Fstable.git misc: mei: client.c: return negative error code in mei_cl_write [ Upstream commit 8f06aee8089cf42fd99a20184501bd1347ce61b9 ] mei_msg_hdr_init() return negative error code, rets should be 'PTR_ERR(mei_hdr)' rather than '-PTR_ERR(mei_hdr)'. Fixes: 0cd7c01a60f8 ("mei: add support for mei extended header.") Signed-off-by: Su Hui Link: https://lore.kernel.org/r/20231120095523.178385-1-suhui@nfschina.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 96f4e59c32a54..9fc58e4032295 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -1975,7 +1975,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb) mei_hdr = mei_msg_hdr_init(cb); if (IS_ERR(mei_hdr)) { - rets = -PTR_ERR(mei_hdr); + rets = PTR_ERR(mei_hdr); mei_hdr = NULL; goto err; }