From: Mukund Sivaraman Date: Thu, 31 Jan 2013 00:38:59 +0000 (+0530) Subject: [2656] Check that origin argument is used for relative names X-Git-Tag: bind10-1.0.0-rc-release~49 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=271e37c6b0befddbf9291577460868f0c67ea428;p=thirdparty%2Fkea.git [2656] Check that origin argument is used for relative names --- diff --git a/src/lib/dns/tests/rdata_cname_unittest.cc b/src/lib/dns/tests/rdata_cname_unittest.cc index 17df1ea8fc..c00cab7e1d 100644 --- a/src/lib/dns/tests/rdata_cname_unittest.cc +++ b/src/lib/dns/tests/rdata_cname_unittest.cc @@ -96,6 +96,13 @@ TEST_F(Rdata_CNAME_Test, createFromLexer) { EXPECT_EQ(0, rdata_cname.compare( *test::createRdataUsingLexer(RRType::CNAME(), RRClass::IN(), "cn.example.com."))); + + // test::createRdataUsingLexer() constructs relative to + // "example.org." origin. + EXPECT_EQ(0, generic::CNAME("cname10.example.org.").compare( + *test::createRdataUsingLexer(RRType::CNAME(), RRClass::IN(), + "cname10"))); + // Extra text at end of line EXPECT_FALSE(test::createRdataUsingLexer(RRType::CNAME(), RRClass::IN(), "cname.example.com. extra.")); diff --git a/src/lib/dns/tests/rdata_dname_unittest.cc b/src/lib/dns/tests/rdata_dname_unittest.cc index 3101f7514e..5b6d9ac4ee 100644 --- a/src/lib/dns/tests/rdata_dname_unittest.cc +++ b/src/lib/dns/tests/rdata_dname_unittest.cc @@ -98,6 +98,13 @@ TEST_F(Rdata_DNAME_Test, createFromLexer) { EXPECT_EQ(0, rdata_dname.compare( *test::createRdataUsingLexer(RRType::DNAME(), RRClass::IN(), "dn.example.com."))); + + // test::createRdataUsingLexer() constructs relative to + // "example.org." origin. + EXPECT_EQ(0, generic::DNAME("dname8.example.org.").compare( + *test::createRdataUsingLexer(RRType::DNAME(), RRClass::IN(), + "dname8"))); + // Extra text at end of line EXPECT_FALSE(test::createRdataUsingLexer(RRType::DNAME(), RRClass::IN(), "dname.example.com. extra.")); diff --git a/src/lib/dns/tests/rdata_srv_unittest.cc b/src/lib/dns/tests/rdata_srv_unittest.cc index 36dd653fd1..a3d772115c 100644 --- a/src/lib/dns/tests/rdata_srv_unittest.cc +++ b/src/lib/dns/tests/rdata_srv_unittest.cc @@ -126,6 +126,12 @@ TEST_F(Rdata_SRV_Test, createFromLexer) { *test::createRdataUsingLexer(RRType::SRV(), RRClass::IN(), "1 5 1500 a.example.com."))); + // test::createRdataUsingLexer() constructs relative to + // "example.org." origin. + EXPECT_EQ(0, in::SRV("1 5 1500 server16.example.org.").compare( + *test::createRdataUsingLexer(RRType::SRV(), RRClass::IN(), + "1 5 1500 server16"))); + // Exceptions cause NULL to be returned. // Bad priority