From: Pavel Filipenský Date: Wed, 3 Jul 2024 15:33:20 +0000 (+0200) Subject: s3:rpcclient: Initialize spoolss_DriverDirectoryInfo info X-Git-Tag: tdb-1.4.11~184 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=275ffbf5606735942b96afdaaa28fd824fe220ef;p=thirdparty%2Fsamba.git s3:rpcclient: Initialize spoolss_DriverDirectoryInfo info Error: UNINIT (CWE-457): samba-4.20.0rc2/source3/rpcclient/cmd_spoolss.c:1530: var_decl: Declaring variable "info" without initializer. samba-4.20.0rc2/source3/rpcclient/cmd_spoolss.c:1578: uninit_use_in_call: Using uninitialized value "info" when calling "display_printdriverdir_1". 1576| 1577| if (W_ERROR_IS_OK(result)) { 1578|-> display_printdriverdir_1(&info.info1); 1579| } 1580| Signed-off-by: Pavel Filipenský Reviewed-by: Volker Lendecke --- diff --git a/source3/rpcclient/cmd_spoolss.c b/source3/rpcclient/cmd_spoolss.c index 40ee3e7f874..17ba74c333f 100644 --- a/source3/rpcclient/cmd_spoolss.c +++ b/source3/rpcclient/cmd_spoolss.c @@ -1527,7 +1527,7 @@ static WERROR cmd_spoolss_getdriverdir(struct rpc_pipe_client *cli, const char *env = SPOOLSS_ARCHITECTURE_NT_X86; DATA_BLOB buffer; uint32_t offered; - union spoolss_DriverDirectoryInfo info; + union spoolss_DriverDirectoryInfo info = {}; uint32_t needed; struct dcerpc_binding_handle *b = cli->binding_handle;